Remove in app payment for unit tests on macOS for CI #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1082 +/- ##
=======================================
Coverage 36.78% 36.78%
=======================================
Files 132 132
Lines 7630 7630
=======================================
Hits 2807 2807
Misses 4823 4823 ☔ View full report in Codecov by Sentry. |
BPerlakiH
force-pushed
the
turn-off-macos-unit-tests-for-ci
branch
from
0d06d2b to
e134d76
Compare
BPerlakiH
force-pushed
the
turn-off-macos-unit-tests-for-ci
branch
from
e134d76 to
02e9408
Compare
BPerlakiH
changed the title
|
@kelson42 I've updated this PR, and built it 6 times with success: Thank you for the hint @rgaudin: indeed when I moved the removal before the build step (as suggested) it is working as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1081